Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strengthen the types for Bridge events #3838

Merged
merged 2 commits into from
Oct 19, 2021
Merged

Strengthen the types for Bridge events #3838

merged 2 commits into from
Oct 19, 2021

Commits on Oct 16, 2021

  1. Strengthen the types for Bridge events

    I have created type definitions for all the event names that are sent
    across the different frames using various `Bridge`s. It is based on the
    previous `bridge-events.js`. I broke down the events in four sections
    based on the direction of the messages:
    
    * guest -> sidebar events
    * host -> sidebar events
    * sidebar -> guest/s events
    * sidebar -> host events
    
    For those events that didn't have a description I added one.
    
    This is more stringent and less verbose than the previous lookup system.
    esanzgar committed Oct 16, 2021
    Configuration menu
    Copy the full SHA
    1748ca4 View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2021

  1. Apply suggestions from code review

    Co-authored-by: Robert Knight <robertknight@gmail.com>
    esanzgar and robertknight committed Oct 19, 2021
    Configuration menu
    Copy the full SHA
    b36b8e6 View commit details
    Browse the repository at this point in the history