Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enforce the use of enums for Bridge events #3833

Closed
wants to merge 3 commits into from
Closed

Re-enforce the use of enums for Bridge events #3833

wants to merge 3 commits into from

Commits on Oct 14, 2021

  1. Re-enforce the use of enums for Bridge events 

    In contrast to #3829, we have
decided to re-enforce the use of the lookup enums for the event names
used by `Bridge`.

I have added definitions for all the events that are sent across the
different frames using various `Bridge`s. I broke down the events into
four sections based on the direction of the messages:

* guest -> sidebar events
* host -> sidebar events
* sidebar -> guest/s events
* sidebar -> host events
    @esanzgar
    esanzgar committed Oct 14, 2021
    Configuration menu
    Copy the full SHA
    b9a2b6c View commit details
    Browse the repository at this point in the history

  2. Adoption of Bridge event enums in tests 

    For greater consistency, we decided to use the enums defined in
`brdige-events.js` everywhere, including test.
    @esanzgar
    esanzgar committed Oct 14, 2021
    Configuration menu
    Copy the full SHA
    49dd416 View commit details
    Browse the repository at this point in the history

  3. Order imports alphabetically 

    Reorder imports according to the team conventions.
    @esanzgar
    esanzgar committed Oct 14, 2021
    Configuration menu
    Copy the full SHA
    7bb7b76 View commit details
    Browse the repository at this point in the history