Fix minor issues related index to generated time

CHANGELOG.md

@@ -7,7 +7,10 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 
 ## [Unreleased]
 
-- Update generated timestamp field in index.yaml when the index is modified.
+### Changed
+
+- `generated` timestamp field in the index file is now updated with current time
+on push, reindex and delete.
 
 ## [0.16.0] - 2023-12-07
 

cmd/helm-s3/delete.go

@@ -103,6 +103,7 @@ func (act *deleteAction) run(ctx context.Context) error {
 	if err != nil {
 		return err
 	}
+	idx.UpdateGeneratedTime()
 
 	idxReader, err := idx.Reader()
 	if err != nil {

cmd/helm-s3/push.go

@@ -211,10 +211,8 @@ func (act *pushAction) run(ctx context.Context) error {
 		return errors.WithMessage(err, "add/replace chart in the index")
 	}
 	idx.SortEntries()
-
-	// #142: update timestamp of the generated field	
-	idx.TimeStamp()
-
+	idx.UpdateGeneratedTime()
+
 	idxReader, err := idx.Reader()
 	if err != nil {
 		return errors.WithMessage(err, "get index reader")

cmd/helm-s3/reindex.go

@@ -105,6 +105,7 @@ func (act *reindexAction) run(ctx context.Context) error {
 			}
 		}
 		idx.SortEntries()
+		idx.UpdateGeneratedTime()
 
 		builtIndex <- idx
 	}()

internal/helmutil/index.go

@@ -29,7 +29,7 @@ type Index interface {
 	// SortEntries sorts the entries by version in descending order.
 	SortEntries()
 
-	// Updated Last indexation TimeStamp.
+	// UpdateGeneratedTime updates time when the index was generated.
 	UpdateGeneratedTime()
 
 	// MarshalBinary encodes index to a binary form.

internal/helmutil/index_v2.go

@@ -122,7 +122,7 @@ func (idx *IndexV2) SortEntries() {
 }
 
 func (idx *IndexV2) UpdateGeneratedTime() {
-	idx.index.Generated = time.Now()
+	idx.index.Generated = time.Now().UTC()
 }
 
 func (idx *IndexV2) MarshalBinary() (data []byte, err error) {

internal/helmutil/index_v2_test.go

@@ -123,7 +123,7 @@ func TestIndexV2_AddOrReplace(t *testing.T) {
 	})
 }
 
-func TestIndexV2_Timestamp(t *testing.T) {
+func TestIndexV2_UpdateGeneratedTime(t *testing.T) {
 	idx := IndexV2{
 		index: &repo.IndexFile{
 			APIVersion: "foo",

internal/helmutil/index_v3.go

@@ -124,7 +124,7 @@ func (idx *IndexV3) SortEntries() {
 }
 
 func (idx *IndexV3) UpdateGeneratedTime() {
-	idx.index.Generated = time.Now()
+	idx.index.Generated = time.Now().UTC()
 }
 
 func (idx *IndexV3) MarshalBinary() (data []byte, err error) {

internal/helmutil/index_v3_test.go

@@ -123,7 +123,7 @@ func TestIndexV3_AddOrReplace(t *testing.T) {
 	})
 }
 
-func TestIndexV3_Timestamp(t *testing.T) {
+func TestIndexV3_UpdateGeneratedTime(t *testing.T) {
 	idx := IndexV3{
 		index: &repo.IndexFile{
 			APIVersion: "foo",

tests/e2e/push_test.go

@@ -36,8 +36,28 @@ func TestPush(t *testing.T) {
 	setupRepo(t, repoName, repoDir)
 	defer teardownRepo(t, repoName)
 
+	tmpdir, err := os.MkdirTemp("", t.Name())
+	require.NoError(t, err)
+	defer os.RemoveAll(tmpdir)
+
+	// Fetch the repo index before push to get generated time.
+
+	indexFile := filepath.Join(tmpdir, "index.yaml")
+
+	err = mc.FGetObject(repoName, repoDir+"/index.yaml", indexFile, minio.GetObjectOptions{})
+	require.NoError(t, err)
+
+	idx, err := repo.LoadIndexFile(indexFile)
+	require.NoError(t, err)
+
+	assert.NotEmpty(t, idx.Generated)
+
+	idxGeneratedTimeBeforePush := idx.Generated
+
+	// Push chart.
+
 	cmd, stdout, stderr := command(fmt.Sprintf("helm s3 push %s %s", chartFilepath, repoName))
-	err := cmd.Run()
+	err = cmd.Run()
 	assert.NoError(t, err)
 	assertEmptyOutput(t, nil, stderr)
 	assert.Contains(t, stdout.String(), "Successfully uploaded the chart to the repository.")
@@ -64,10 +84,6 @@ func TestPush(t *testing.T) {
 
 	// Check that pushed chart can be fetched.
 
-	tmpdir, err := os.MkdirTemp("", t.Name())
-	require.NoError(t, err)
-	defer os.RemoveAll(tmpdir)
-
 	cmd, stdout, stderr = command(fmt.Sprintf("helm fetch %s/%s --version %s --destination %s", repoName, chartName, chartVersion, tmpdir))
 	err = cmd.Run()
 	assert.NoError(t, err)
@@ -83,6 +99,16 @@ func TestPush(t *testing.T) {
 
 	expected = "The chart already exists in the repository and cannot be overwritten without an explicit intent."
 	assert.Contains(t, stderr.String(), expected)
+
+	// Fetch the repo index again and check that generated time was updated.
+
+	err = mc.FGetObject(repoName, repoDir+"/index.yaml", indexFile, minio.GetObjectOptions{})
+	require.NoError(t, err)
+
+	idx, err = repo.LoadIndexFile(indexFile)
+	require.NoError(t, err)
+
+	assert.Greater(t, idx.Generated, idxGeneratedTimeBeforePush)
 }
 
 func TestPushContentType(t *testing.T) {
@@ -308,61 +334,6 @@ func TestPushRelative(t *testing.T) {
 	assert.FileExists(t, filepath.Join(tmpdir, chartFilename))
 }
 
-func TestGeneratedTimeStamp(t *testing.T) {
-	t.Log("Test generated timestamp is updated on push")
-
-	const (
-		repoName      = "test-push-index-timestamp"
-		repoDir       = "charts"
-		chartName     = "foo"
-		chartVersion  = "1.2.3"
-		chartFilename = "foo-1.2.3.tgz"
-		chartFilepath = "testdata/" + chartFilename
-	)
-
-	setupRepo(t, repoName, repoDir)
-	defer teardownRepo(t, repoName)
-
-	cmd, stdout, stderr := command(fmt.Sprintf("helm s3 push %s %s", chartFilepath, repoName))
-	err := cmd.Run()
-	assert.NoError(t, err)
-	assertEmptyOutput(t, stdout, stderr)
-
-	tmpdir, err := ioutil.TempDir("", t.Name())
-	require.NoError(t, err)
-	defer os.RemoveAll(tmpdir)
-
-	// Fetch the repo index and register the generated timestamp
-	indexFile := filepath.Join(tmpdir, "index.yaml")
-
-	err = mc.FGetObject(repoName, repoDir+"/index.yaml", indexFile, minio.GetObjectOptions{})
-	require.NoError(t, err)
-
-	idx, err := repo.LoadIndexFile(indexFile)
-	require.NoError(t, err)
-
-	generatedOld := idx.Generated
-
-	time.Sleep(time.Second)
-
-	// Force push the chart and register the generated timestamp
-	cmd, stdout, stderr = command(fmt.Sprintf("helm s3 push %s %s --force", chartFilepath, repoName))
-	err = cmd.Run()
-	assert.NoError(t, err)
-	assertEmptyOutput(t, stdout, stderr)
-
-	err = mc.FGetObject(repoName, repoDir+"/index.yaml", indexFile, minio.GetObjectOptions{})
-	require.NoError(t, err)
-
-	idx, err = repo.LoadIndexFile(indexFile)
-	require.NoError(t, err)
-
-	generatedNew := idx.Generated
-	// t.Logf("\ngeneratedOld:%s\ngeneratedNew:%s", generatedOld.String(), generatedNew.String())
-	// Assert generatedNew is greater than generatedOld
-	assert.True(t, generatedNew.After(generatedOld), "Expected %s greater than %s", generatedNew.String(), generatedOld.String())
-}
-
 func assertEmptyOutput(t *testing.T, stdout, stderr *bytes.Buffer) {
 	t.Helper()