NodeConfig was reading a particular config from default on every start up #739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bombe
approved these changes
Aug 14, 2021
src/freenet/node/Node.java
Outdated
| public Integer get() { | ||
| return ResizablePersistentIntBuffer.getPersistenceTime(); | ||
| } | ||
| public Integer get() { return storeSaltHashSlotFilterPersistenceTime;} |
There was a problem hiding this comment.
Please don’t collapse this into a single line; otherwise this looks good.
There was a problem hiding this comment.
Done! Yeah that looked weird!
|
🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This particular config value is currently retrieved from the class default value and not from the config as expected.