fix busy loop if all darknet peers are connected. #1031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArneBab
force-pushed
the
dns-requester-avoid-busy-loop-on-dns-request
branch
from
9d51ca6 to
060fab4
Compare
bertm
approved these changes
Jan 5, 2025
There was a problem hiding this comment.
Yikes, good catch, the early return had unintentional side effects.
This could easily have been avoided if the code performing the work would not have been mixed with the code in charge of scheduling that work. That could be accomplished by moving the waiting code from realRun() to run().
The current change by itself is fine though.
|
Merged — thank you for your review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This needs to be merged and released as emergency release, because it turns darknet nodes with 100% connected nodes into electrical heaters.