Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NullPointerException when disabling and reenabling SSL #1027

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

torusrxxx
Copy link
Contributor

Setting keyStore to null will result in NullPointerException when SSL is reenabled and loadKeyStoreAndCreateCertificate is executed. Load a null key store instead.
Avoid adding strict-transport-security header twice. The second addition of strict-transport-security header does not check whether fproxy SSL is enabled because container is not a static member. As a result, strict-transport-security header is sent when SSL is enabled but fproxy SSL is disabled.

@ArneBab ArneBab merged commit 3a315f8 into hyphanet:next Jan 6, 2025
1 check passed
@ArneBab
Copy link
Contributor

ArneBab commented Jan 6, 2025

Merged — thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants