Add margin-*, padding-*, scroll-snap-* CSS properties #1011
Conversation
| } | ||
| else if("scroll-snap-align".equalsIgnoreCase(element)) | ||
| { | ||
| auxilaryVerifiers[82]=new CSSPropertyVerifier(Arrays.asList("none","start","end","center"),null,null,null,true); |
There was a problem hiding this comment.
Is there any reason for not describing this auxilaryVerifiers entry and the ones for scroll-snap-type in the static initializer together with the existing ones?
There was a problem hiding this comment.
There are lots of such cases, I think it is because if there's no use of this property in the CSS, then it does not need to initialize this entry.
| } | ||
| else if("margin-inline".equalsIgnoreCase(element)) | ||
| { | ||
| elementVerifiers.put(element,new CSSPropertyVerifier(null,ElementInfo.VISUALMEDIA,null,Arrays.asList("80<1,2>"))); |
There was a problem hiding this comment.
Can we refer to the existing auxilaryVerifiers[36] that is used for margin (after moving that one to the static initializer) as 36<1,2> instead of adding yet another verifier?
(same for margin-block)
| } | ||
| else if("margin-block-start".equalsIgnoreCase(element)) | ||
| { | ||
| elementVerifiers.put(element,new CSSPropertyVerifier(Arrays.asList("auto"),ElementInfo.VISUALMEDIA,Arrays.asList("le","pe"))); |
There was a problem hiding this comment.
Can this refer to auxilaryVerifiers[36] as 36 instead of hard-coding length | percentage?
(same for margin-block-end, similar for all the others padding/margin variants added)
|
b4d5b83 looks good, the rest is reviewed by bertm ⇒ merged. Thank you! |
Supported the following new CSS properties: