Add Branch-Specific Key Decoding in GitHub Actions Workflow #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
tripledoublev
commented
Nov 22, 2023
tripledoublev
commented
- Update deploy.yml to decode different keys for staging and production.
- Implement conditional steps to handle 'staging' and 'master' branches.
- Update deploy.yml to decode different keys for staging and production. - Implement conditional steps to handle 'staging' and 'master' branches.
- Modified the GitHub Actions workflow to handle key decoding for both direct pushes and pull requests. - Added conditions to check the target branch (`base_ref`) in PRs, ensuring the correct environment keys are decoded.
…ontext
This commit enhances the GitHub Actions workflow by introducing two key changes:
1. `Set Site URL based on branch`: This update ensures that the main site URL in `_config.yml` is dynamically set to the production URL ("https://hypha.coop") when either pushing to the `master` branch or creating a pull request targeting `master`. This change supports proper environment configuration for production deployments.
2. `Set DP Social URL based on branch`: This addition modifies the `activity_pub` URL in `_config.yml` based on the branch context. For pushes or pull requests targeting the `master` branch, it sets the URL to the production environment (`SOCIAL_DP_PROD`). For the `staging` branch, it uses the staging environment URL (`SOCIAL_DP_STAGING`). This ensures that the correct external service URLs are used for different deployment stages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.