Feature/fix imports #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you please change the scope of logback back to "test" or to "runtime". I don't want to force the user to use logback, so we should avoid compile time dependency on it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed imports by 1) don't write interface class file during parseInterface, but save all the info to a definitions array. 2) Track the structs created in each package in class variable structPackages. 3) After xml has been parsed, write out all the interface classes from the definitions, using the packages saved in 2) to create the import statements.
All the firewalld objects provided earlier now compile cleanly. The code is not that elegant, but since you are re-visting this area anyway...