-
-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Potential leak of application internals in ExportedObject.getAnnotations() #18
Comments
Thanks for the report. I don't have much spare time atm, but I hope the fix I just commited will handle this issue |
I have not tried it, but 01381b9 appears to break all annotations, as If I may make a recommendation, create a This creates an explicit API that pushes the security concerns onto the consumer of dbus-java, allowing them to make those security decisions. Further, as far as I'm aware, annotations within introspection data that don't pertain to D-Bus proper aren't used by any of the standard tooling and thus are rather useless to anyone that doesn't explicitly consume them via the Therefore, this could potentially be moot and only the annotations that D-Bus cares about could be checked (i.e. calling Thank you for the response - the concern is appreciated. Just a suggestion. Thank you for your response. |
If you already have a proper fix, please provide a pull request and will merge it. |
any news on this? |
as there is no feedback yet, I assume this issue is fixed. |
If a
DBusInterface
adds any class-level annotations that have avalue()
method, even if they do not pertain to DBus itself, they will get leaked as introspection data to any clients that care.In the case of an annotation including information pertaining to implementation details (including crypto suites, hard-coded hostnames, etc.) this information would be freely transmitted to the user.
This is because
ExportedObject.getAnnotations()
does not filter which annotations it includes in the introspection data:https://github.com/hypfvieh/dbus-java/blob/master/src/main/java/org/freedesktop/dbus/messages/ExportedObject.java#L56-L67
The text was updated successfully, but these errors were encountered: