Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor DBusDaemon to start embedded #16

Closed
lbeuster opened this issue May 17, 2018 · 4 comments
Closed

Refactor DBusDaemon to start embedded #16

lbeuster opened this issue May 17, 2018 · 4 comments

Comments

@lbeuster
Copy link

I'd like to do minimal possible refactoring to start the DBusDaemon embedded (e.g. for tests). Currently its only possible to do that with some reflection hacking.
What do you think?

@hypfvieh
Copy link
Owner

Did you pull the latest changes? I'm just asking, because your latest PullRequest has merge conflicts.

I merged the changes of dbus-java-3.0 branch to the master branch some hours ago.
I think it's better to do all your change requests for version 3.0 instead of 2.x.

If your desired changes are not part of my refactorings (I changed a lot, maybe DbusDaemon is already fixed), please go on and provide a pull request.

@lbeuster
Copy link
Author

No, I didn't. First have to figure out how to update my fork. Will do that now ;)

@lbeuster
Copy link
Author

I created a pull request: #24

I tried to do minimal changes to the existing code.

hypfvieh added a commit that referenced this issue Jul 30, 2018
#16 Refactor DBusDaemon to start embedded
@hypfvieh
Copy link
Owner

Thanks for your PR, changes have been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants