Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: upgrade react version #875

Conversation

wangyantong2000
Copy link
Collaborator

Brief Information

This pull request is in the type of (more info about types):

  • build
  • ci
  • docs
  • feat
  • fix
  • perf
  • refactor
  • test

Related issues (all available keywords):

Details

Upgrade the React version to 18+

Checklist

Others

@wangyantong2000
Copy link
Collaborator Author

@Xsy41. Need your help to check if it is still running normally and if there are any omissions.

@Xsy41
Copy link
Contributor

Xsy41 commented Sep 23, 2024

@Xsy41. Need your help to check if it is still running normally and if there are any omissions.

It's checked out. There's no problem.

@wangyantong2000
Copy link
Collaborator Author

wangyantong2000 commented Sep 23, 2024

@YaoYao-Pig also wants to participate in this project and you can conduct a test on this PR first.

@wangyantong2000
Copy link
Collaborator Author

Unfortunately, the content in the NativePopover.tsx file has not been improved. People with relevant knowledge can provide assistance. I will move on to other content first.

@wangyantong2000
Copy link
Collaborator Author

Unfortunately, the content in the NativePopover.tsx file has not been improved. People with relevant knowledge can provide assistance. I will move on to other content first.

Thank you to @Xsy41 and @YaoYao-Pig for pointing out mistakes and helping to correct them. Everyone can try again now, there shouldn't be any problems.

@Xsy41
Copy link
Contributor

Xsy41 commented Sep 25, 2024

Unfortunately, the content in the NativePopover.tsx file has not been improved. People with relevant knowledge can provide assistance. I will move on to other content first.

Thank you to @Xsy41 and @YaoYao-Pig for pointing out mistakes and helping to correct them. Everyone can try again now, there shouldn't be any problems.

Yes, it is no longer a problem.

@wangyantong2000 wangyantong2000 marked this pull request as ready for review September 25, 2024 06:23
@YaoYao-Pig
Copy link

Unfortunately, the content in the NativePopover.tsx file has not been improved. People with relevant knowledge can provide assistance. I will move on to other content first.

Thank you to @Xsy41 and @YaoYao-Pig for pointing out mistakes and helping to correct them. Everyone can try again now, there shouldn't be any problems.

OK!I think there are no problem now

@wangyantong2000 wangyantong2000 merged commit 0f91cac into hypertrons:master Sep 25, 2024
2 checks passed
@HalloMelon HalloMelon added this to the 1.9.9 milestone Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants