Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: native popover broken after tab switch #818

Merged

Conversation

tyn1998
Copy link
Member

@tyn1998 tyn1998 commented May 18, 2024

Brief Information

This pull request is in the type of (more info about types):

  • build
  • ci
  • docs
  • feat
  • fix
  • perf
  • refactor
  • test

Related issues (all available keywords):

Details

Add an click event listener for hiding the popover when the anchor element is clicked. In this way, the popover is cleared by a React methodunmountComponentAtNode rather by the GitHub code.

Checklist

Others

@tyn1998 tyn1998 requested a review from HalloMelon May 18, 2024 15:00
@tyn1998 tyn1998 merged commit b7df0ea into hypertrons:master May 18, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] native popover broken after tab switch
2 participants