Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: repo collection (final) #730

Draft
wants to merge 11 commits into
base: master
Choose a base branch
from
Draft

feat: repo collection (final) #730

wants to merge 11 commits into from

Conversation

tyn1998
Copy link
Member

@tyn1998 tyn1998 commented Aug 27, 2023

After #713 and #716 are fully merged into this branch, the PR should be merged into master.

@tyn1998
Copy link
Member Author

tyn1998 commented Aug 27, 2023

Hi @wxharry, the modal view you provided for testing purpose doen't work on my computer.

image

@wxharry
Copy link
Collaborator

wxharry commented Aug 30, 2023

Hi @wxharry, the modal view you provided for testing purpose doen't work on my computer.

Hi, can you provide more info from the console? I cannot reproduce this on my side.

@tyn1998
Copy link
Member Author

tyn1998 commented Sep 3, 2023

@wxharry Sorry, I might not reload Hypercrx from chrome://extensions/ the other day. It works well actually:

image

@wxharry
Copy link
Collaborator

wxharry commented Oct 16, 2023

After #713 and #716 are fully merged into this branch, the PR should be merged into master.

This PR should be merged manually using a merge commit.

wxharry and others added 3 commits October 19, 2023 00:01
* feat: developed RepoCollection Button through antd component

* feat: implement LocalStorage,SetDefault,DeleteCollection,AddCurRepo feature

* style: yarn run prettier for index.scss

* feat: refactor view

* feat: implement storage feature

* feat: implement collection modal from popup button

* feat: implement collection modal using tabs and repo list beside

* feat: implement collection modal from repository dropdown click

* feat: solve reopen modal problem

* feat: implement collection editor function (quick import need to be done)

* feat: add judgment for whether there is initial data

* feat: create CollectionEditor component

* feat: use GitHub REST API to get repo and its description

* feat: implement CollectionEditor add and edit feature

* feat: solve formatting and naming issues

* feat: refactor data structure

* refactor: implement the collection button in the original GitHub style (step 1)

* chore: update yarn.lock

* fix: update module import

* chore: update yarn.lock

* fix: duplicate rendering after tab switches

* fix: prevent duplicate finally

* refactor: give CollectionModal a separate directory

* refactor: CollectionList (30%) and AddToCollections (1%)

* feat: support basic interactions with CollectionButton

* chore: disable charts-design

* chore: allow overflow when there are many exsiting collections

* chore: add comments

* chore: add manage button in AddToCollections

* refactor: a possible final directory

* chore: support to open modal from CollectionList

* fix: fix typo

* feat: add confirm check before collection deletion

* feat: set default key for Table and add Radio for quick import (User/Organization)

* refactor: move custom type definition to context.ts

* refactor: use constate to better manage locally global state

* feat: store and useStore for repo-collection

* chore: update repo name after turbo:restore

* feat: replace some part with real data

* feat: AddToCollections(100%)

* fix: a simple lock mechanism to prevent concurrent updates in store.ts

* feat: implement CollectionDisplayModal and rename filename

* refactor: rename view.tsx

* feat: add divider for footer in AddToCollections

* refactor: remove redundant initialization

* refactor: rollback and delete displayModal

* feat: implement of CollectionManageModal

* feat: implement of CollectionEditor confirm

* feat: use await/async function

* chore: fix typo and add validator for duplicate collection name

* style: maximize the collection modal size

---------

Co-authored-by: Lam Tang <tangyenan@gmail.com>
* feat: Implement brief layouts and chart styles

* feat: Implemented BarChart、StackedBarChart, PieChart

* feat: Implemented BoxplotChart, SankeyChart

* feat: Implemented GridLayout, Simple Chart Display, Implemented 'Highlight Specific Charts by Clicking the Menu Bar'

* feat: Implemented NumericPanel and made adjustments to the BarChart,StackedBarChart and Boxplot

* feat: Removed the deprecated gridlayout file

* feat: Modify the 'get newest month' function

* feat: merge collection Modal
@wxharry
Copy link
Collaborator

wxharry commented Oct 22, 2023

Please remember to improve your comments in the code. Make sure it is descriptive and simple in English, ask gpt to do it would be a good choice.

@wxharry
Copy link
Collaborator

wxharry commented Oct 26, 2023

Resolve #756

@andyhuang18
Copy link
Collaborator

Hi~ It is now possible to add a repository by directly entering the repository name. A new add option FullName has been added. However, due to the different refresh mechanisms, the middle panel cannot be refreshed in time after editing, but you can still see the newly added repository after manual refresh ~ as shown in the demo video below:

demo.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants