Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add options page && popup page #71

Merged
merged 3 commits into from
Mar 24, 2021

Conversation

LiuChangFreeman
Copy link
Contributor

Purpose

This commit implements the basic component for options page and popup page using Fluent-UI.
image

Proposed changes

We can properly write code for the two pages.

Open Questions and Pre-Merge TODOs

  • Use github checklists. When solved, check the box and explain the answer.

Types of changes

What types of changes does your code introduce to hypertrons-crx?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Approach

How does this change address the problem?

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments (Optional)

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...
Links to blog posts, patterns, libraries or addons used to solve this problem

Copy link
Contributor

@heming6666 heming6666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @LiuChangFreeman .

/approve

@menbotics menbotics bot added the pull/approved If a pull is approved, it will be automatically merged label Mar 24, 2021
@menbotics menbotics bot merged commit 0bdef7f into hypertrons:master Mar 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pull/approved If a pull is approved, it will be automatically merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants