Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adds support for default max spans limit helm config #291

Merged
merged 2 commits into from
Nov 25, 2021

Conversation

kotharironak
Copy link
Contributor

As described as part of this PR (#290), we have added support for limiting trace size across all tenants.

This PR,

@codecov
Copy link

codecov bot commented Nov 25, 2021

Codecov Report

Merging #291 (7b4a309) into main (cdbd7b4) will decrease coverage by 0.02%.
The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #291      +/-   ##
============================================
- Coverage     79.60%   79.58%   -0.03%     
+ Complexity     1268     1265       -3     
============================================
  Files           112      112              
  Lines          4937     4937              
  Branches        451      451              
============================================
- Hits           3930     3929       -1     
  Misses          806      806              
- Partials        201      202       +1     
Flag Coverage Δ
unit 79.58% <66.66%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rtrace/core/rawspansgrouper/RawSpansProcessor.java 81.57% <66.66%> (ø)
...race/core/rawspansgrouper/TraceEmitPunctuator.java 74.56% <0.00%> (-0.88%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cdbd7b4...7b4a309. Read the comment docs.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@kotharironak kotharironak merged commit fcd88a5 into main Nov 25, 2021
@kotharironak kotharironak deleted the max-span-count-config branch November 25, 2021 09:58
@github-actions
Copy link

Unit Test Results

  74 files  ±0    74 suites  ±0   1m 1s ⏱️ -1s
392 tests ±0  392 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit fcd88a5. ± Comparison against base commit cdbd7b4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants