Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: moving out avro checks as a separate job #289

Merged
merged 4 commits into from
Nov 22, 2021
Merged

Conversation

kotharironak
Copy link
Contributor

@kotharironak kotharironak commented Nov 22, 2021

This PR, separate out avroCompatibilityCheck compatibility check into a different job.
This helps in certain scenarios where we first time adds avro file, and want to skip checks

@codecov
Copy link

codecov bot commented Nov 22, 2021

Codecov Report

Merging #289 (31b6458) into main (85a92cc) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               main     #289   +/-   ##
=========================================
  Coverage     79.20%   79.20%           
  Complexity     1239     1239           
=========================================
  Files           111      111           
  Lines          4880     4880           
  Branches        442      442           
=========================================
  Hits           3865     3865           
  Misses          813      813           
  Partials        202      202           
Flag Coverage Δ
unit 79.20% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85a92cc...31b6458. Read the comment docs.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

- name: validate avros
uses: hypertrace/github-actions/gradle@main
with:
args: avroCompatibilityCheck
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this have deps on the build step? If, yes, I will have to add the cache step.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't recall, but you should add the cache step regardless as it caches the gradle binary too. We should probably change the avro plugin so validation does not automatically run on check (the reason for the -x above), but that'd be a bit of a breaking change and could cause repos to stop validating entirely, so this is more reasonable right now

@github-actions

This comment has been minimized.

@kotharironak kotharironak marked this pull request as ready for review November 22, 2021 08:57
@github-actions

This comment has been minimized.

@kotharironak kotharironak merged commit 431d690 into main Nov 22, 2021
@kotharironak kotharironak deleted the avro-job branch November 22, 2021 16:41
@github-actions
Copy link

Unit Test Results

  74 files  ±0    74 suites  ±0   1m 7s ⏱️ +5s
389 tests ±0  389 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 431d690. ± Comparison against base commit 85a92cc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants