feat: add forming grpc reqeuest url if rpc attributes are present #280
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For RPC methods, we show URL/URI as a combination of
rpc.service
andrpc.method
. The same information is also available as Span Name - https://github.com/open-telemetry/opentelemetry-specification/blob/3e380e249f60c3a5f68746f5e84d10195ba41a79/specification/trace/semantic_conventions/rpc.md#span-nameIt has been observed that spanName is not correctly set on certain scenarios. However, the span contains
rpc.service
andrpc.method
attribute correctly set. So, as part of this PR, we will first look into RPC attributes if a protocol is grpc, and if those are not present, we will fall back to eventName which is nothing but spanName.Testing
Added unit tests
Checklist: