Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Make entity update async #274

Merged
merged 2 commits into from
Oct 26, 2021
Merged

fix: Make entity update async #274

merged 2 commits into from
Oct 26, 2021

Conversation

laxman-traceable
Copy link
Contributor

Description

Making entity update async and non-blocking

Testing

Unit testing

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

Documentation

NA

@laxman-traceable
Copy link
Contributor Author

PR co-authored by @aaron-steinfeld

@github-actions

This comment has been minimized.

@codecov
Copy link

codecov bot commented Oct 26, 2021

Codecov Report

Merging #274 (e2c4857) into main (c4659db) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##               main     #274   +/-   ##
=========================================
  Coverage     80.45%   80.46%           
  Complexity     1209     1209           
=========================================
  Files           106      106           
  Lines          4662     4663    +1     
  Branches        436      435    -1     
=========================================
+ Hits           3751     3752    +1     
  Misses          710      710           
  Partials        201      201           
Flag Coverage Δ
unit 80.46% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../accessor/entities/DefaultTraceEntityAccessor.java 96.62% <100.00%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4659db...e2c4857. Read the comment docs.

@github-actions

This comment has been minimized.

Copy link
Contributor

@aaron-steinfeld aaron-steinfeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you get a chance to test this out? conceptually it looks fine (not sure if anything changed from my suggestion), but I never actually tried it to see if it helped.

@laxman-traceable
Copy link
Contributor Author

laxman-traceable commented Oct 26, 2021

Did you get a chance to test this out? conceptually it looks fine (not sure if anything changed from my suggestion), but I never actually tried it to see if it helped.

Yes @aaron-steinfeld. Deployed and verified this on staging cluster with local build.
Enricher performance has been improved significantly on test cluster.

@laxman-traceable laxman-traceable merged commit 73a9194 into main Oct 26, 2021
@laxman-traceable laxman-traceable deleted the perf-bug-fix branch October 26, 2021 15:44
@github-actions
Copy link

Unit Test Results

  71 files  ±0    71 suites  ±0   1m 9s ⏱️ +13s
383 tests ±0  383 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 73a9194. ± Comparison against base commit c4659db.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants