-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Make entity update async #274
Conversation
PR co-authored by @aaron-steinfeld |
This comment has been minimized.
This comment has been minimized.
Codecov Report
@@ Coverage Diff @@
## main #274 +/- ##
=========================================
Coverage 80.45% 80.46%
Complexity 1209 1209
=========================================
Files 106 106
Lines 4662 4663 +1
Branches 436 435 -1
=========================================
+ Hits 3751 3752 +1
Misses 710 710
Partials 201 201
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you get a chance to test this out? conceptually it looks fine (not sure if anything changed from my suggestion), but I never actually tried it to see if it helped.
Yes @aaron-steinfeld. Deployed and verified this on staging cluster with local build. |
Description
Making entity update async and non-blocking
Testing
Unit testing
Checklist:
Documentation
NA