Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding enabled, description fields in label app rules #79

Merged
merged 4 commits into from
Nov 15, 2021

Conversation

kamaleshnneerasa
Copy link
Contributor

Description

Please include a summary of the change, motivation and context.

Testing

Please describe the tests that you ran to verify your changes. Please summarize what did you test and what needs to be tested e.g. deployed and tested helm chart locally.

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

Documentation

Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.

@codecov
Copy link

codecov bot commented Nov 5, 2021

Codecov Report

Merging #79 (604ec66) into main (741e465) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main      #79      +/-   ##
============================================
+ Coverage     83.91%   83.92%   +0.01%     
  Complexity      309      309              
============================================
  Files            38       38              
  Lines          1523     1524       +1     
  Branches         46       46              
============================================
+ Hits           1278     1279       +1     
  Misses          213      213              
  Partials         32       32              
Flag Coverage Δ
integration 83.92% <100.00%> (+0.01%) ⬆️
unit 83.09% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rule/config/service/LabelApplicationRuleStore.java 70.00% <ø> (ø)
...fig/service/LabelApplicationRuleValidatorImpl.java 75.96% <100.00%> (+0.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 741e465...604ec66. Read the comment docs.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

saxenakshitiz
saxenakshitiz previously approved these changes Nov 15, 2021
@saxenakshitiz saxenakshitiz self-requested a review November 15, 2021 06:37
@saxenakshitiz saxenakshitiz dismissed their stale review November 15, 2021 06:38

Need one more change

@saxenakshitiz
Copy link
Contributor

Please make this change -

private static final String LABEL_APPLICATION_RULE_CONFIG_RESOURCE_NAME = "label-application-rule-config";
private static final String LABEL_APPLICATION_RULE_CONFIG_RESOURCE_NAMESPACE = "labels";

@github-actions

This comment has been minimized.

@kamaleshnneerasa kamaleshnneerasa merged commit f47974c into main Nov 15, 2021
@kamaleshnneerasa kamaleshnneerasa deleted the ENG-12057 branch November 15, 2021 07:08
@github-actions
Copy link

Unit Test Results

21 files  ±0  21 suites  ±0   42s ⏱️ -3s
78 tests ±0  78 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit f47974c. ± Comparison against base commit 741e465.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants