-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add label fields #73
Add label fields #73
Conversation
Codecov Report
@@ Coverage Diff @@
## main #73 +/- ##
============================================
- Coverage 84.20% 83.91% -0.29%
- Complexity 308 309 +1
============================================
Files 38 38
Lines 1519 1523 +4
Branches 45 46 +1
============================================
- Hits 1279 1278 -1
- Misses 209 213 +4
- Partials 31 32 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
labels-config-service-api/src/main/proto/org/hypertrace/label/config/service/v1/label.proto
Outdated
Show resolved
Hide resolved
labels-config-service-api/src/main/proto/org/hypertrace/label/config/service/v1/label.proto
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
labels-config-service-api/src/main/proto/org/hypertrace/label/config/service/v1/label.proto
Outdated
Show resolved
Hide resolved
labels-config-service-api/src/main/proto/org/hypertrace/label/config/service/v1/label.proto
Outdated
Show resolved
Hide resolved
labels-config-service-api/src/main/proto/org/hypertrace/label/config/service/v1/label.proto
Outdated
Show resolved
Hide resolved
...-service-impl/src/main/java/org/hypertrace/label/config/service/LabelsConfigServiceImpl.java
Outdated
Show resolved
Hide resolved
...-service-impl/src/main/java/org/hypertrace/label/config/service/LabelsConfigServiceImpl.java
Outdated
Show resolved
Hide resolved
...vice-impl/src/test/java/org/hypertrace/label/config/service/LabelsConfigServiceImplTest.java
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
...-service-impl/src/main/java/org/hypertrace/label/config/service/LabelsConfigServiceImpl.java
Outdated
Show resolved
Hide resolved
...-service-impl/src/main/java/org/hypertrace/label/config/service/LabelsConfigServiceImpl.java
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm; let's hold on merge until corresponding work is done in GQL as this is a breaking change and we want to minimize the window of inconsistency.
This comment has been minimized.
This comment has been minimized.
Let's fix snyk then get this merged. |
Description
Please include a summary of the change, motivation and context.
Testing
Please describe the tests that you ran to verify your changes. Please summarize what did you test and what needs to be tested e.g. deployed and tested helm chart locally.
Checklist:
Documentation
Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.