Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add label fields #73

Merged
merged 10 commits into from
Nov 11, 2021
Merged

Add label fields #73

merged 10 commits into from
Nov 11, 2021

Conversation

kamaleshnneerasa
Copy link
Contributor

Description

Please include a summary of the change, motivation and context.

Testing

Please describe the tests that you ran to verify your changes. Please summarize what did you test and what needs to be tested e.g. deployed and tested helm chart locally.

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

Documentation

Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.

@codecov
Copy link

codecov bot commented Oct 19, 2021

Codecov Report

Merging #73 (ca77032) into main (777df10) will decrease coverage by 0.28%.
The diff coverage is 81.48%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main      #73      +/-   ##
============================================
- Coverage     84.20%   83.91%   -0.29%     
- Complexity      308      309       +1     
============================================
  Files            38       38              
  Lines          1519     1523       +4     
  Branches         45       46       +1     
============================================
- Hits           1279     1278       -1     
- Misses          209      213       +4     
- Partials         31       32       +1     
Flag Coverage Δ
integration 83.91% <81.48%> (-0.29%) ⬇️
unit 83.08% <81.48%> (-0.30%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../label/config/service/LabelsConfigServiceImpl.java 85.50% <81.48%> (-3.30%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 777df10...ca77032. Read the comment docs.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

Copy link
Contributor

@aaron-steinfeld aaron-steinfeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm; let's hold on merge until corresponding work is done in GQL as this is a breaking change and we want to minimize the window of inconsistency.

@github-actions

This comment has been minimized.

@aaron-steinfeld
Copy link
Contributor

Let's fix snyk then get this merged.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@saxenakshitiz saxenakshitiz merged commit 741e465 into main Nov 11, 2021
@saxenakshitiz saxenakshitiz deleted the more_label_fields branch November 11, 2021 15:15
@github-actions
Copy link

Unit Test Results

21 files  ±0  21 suites  ±0   45s ⏱️ +7s
78 tests ±0  78 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 741e465. ± Comparison against base commit 777df10.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants