Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add email in config_change_event_value.proto #221

Merged
merged 5 commits into from
Jul 25, 2024

Conversation

siddhant2001
Copy link
Contributor

@siddhant2001 siddhant2001 commented Jul 19, 2024

Capture user email when generating change events. This is required to filter out the names of traceable employees on customers' activity logs.

@siddhant2001 siddhant2001 requested a review from a team as a code owner July 19, 2024 10:55
Copy link

Test Results

121 tests  ±0   121 ✅ ±0   59s ⏱️ -3s
 29 suites ±0     0 💤 ±0 
 29 files   ±0     0 ❌ ±0 

Results for commit c3253da. ± Comparison against base commit f524365.

@hypertrace hypertrace locked and limited conversation to collaborators Jul 19, 2024
@siddhant2001 siddhant2001 reopened this Jul 19, 2024
@@ -15,6 +15,7 @@ message ConfigChangeEventValue {
optional string user_id = 4;
optional string user_name = 5;
string user_email = 7;

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove extra line

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

anujgoyal1
anujgoyal1 previously approved these changes Jul 24, 2024
@siddhant2001 siddhant2001 merged commit 12b471f into main Jul 25, 2024
9 checks passed
@siddhant2001 siddhant2001 deleted the email-in-config-change-event branch July 25, 2024 04:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants