Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Email When Name not present when generating config change events #191

Merged
merged 2 commits into from
Dec 21, 2023

Conversation

harshit-kumar-v2
Copy link
Contributor

Description

For on Prem deployment where keycloak is used as Idp username comes as null in request context. This affects how action logs are displayed - we see userId instead of username (since that is null)

Testing

Please describe the tests that you ran to verify your changes. Please summarize what did you test and what needs to be tested e.g. deployed and tested helm chart locally.

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

Documentation

Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.

@harshit-kumar-v2 harshit-kumar-v2 requested a review from a team as a code owner December 21, 2023 12:42
Copy link

github-actions bot commented Dec 21, 2023

Test Results

118 tests  ±0   118 ✔️ ±0   54s ⏱️ -1s
  29 suites ±0       0 💤 ±0 
  29 files   ±0       0 ±0 

Results for commit d54c5a5. ± Comparison against base commit cf76196.

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Dec 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cf76196) 79.66% compared to head (d54c5a5) 79.66%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #191   +/-   ##
=========================================
  Coverage     79.66%   79.66%           
- Complexity      484      485    +1     
=========================================
  Files            54       54           
  Lines          2414     2414           
  Branches        106      106           
=========================================
  Hits           1923     1923           
  Misses          430      430           
  Partials         61       61           
Flag Coverage Δ
integration 79.66% <100.00%> (ø)
unit 78.19% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@harshit-kumar-v2 harshit-kumar-v2 merged commit 66b1e14 into main Dec 21, 2023
11 checks passed
@harshit-kumar-v2 harshit-kumar-v2 deleted the ENG-38643 branch December 21, 2023 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants