Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add support for does not contain span filter operator #175

Merged
merged 1 commit into from
Sep 1, 2023

Conversation

SrikarMannepalli
Copy link
Contributor

Description

This PR adds support for does not contain span filter operator.

Testing

Added unit tests.

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

@SrikarMannepalli SrikarMannepalli requested a review from a team as a code owner September 1, 2023 09:36
@SrikarMannepalli SrikarMannepalli changed the title add support for does not contain span filter operator chore: add support for does not contain span filter operator Sep 1, 2023
@github-actions
Copy link

github-actions bot commented Sep 1, 2023

Test Results

115 tests  ±0   115 ✔️ ±0   1m 26s ⏱️ +11s
  29 suites ±0       0 💤 ±0 
  29 files   ±0       0 ±0 

Results for commit 5785ed8. ± Comparison against base commit 27095cc.

@codecov
Copy link

codecov bot commented Sep 1, 2023

Codecov Report

Merging #175 (5785ed8) into main (27095cc) will decrease coverage by 1.61%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main     #175      +/-   ##
============================================
- Coverage     79.92%   78.31%   -1.61%     
  Complexity      476      476              
============================================
  Files            54       53       -1     
  Lines          2381     2366      -15     
  Branches        103      104       +1     
============================================
- Hits           1903     1853      -50     
- Misses          420      451      +31     
- Partials         58       62       +4     
Flag Coverage Δ
integration ?
unit 78.31% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...onfig/span/processing/utils/SpanFilterMatcher.java 92.75% <100.00%> (+0.10%) ⬆️

... and 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@SrikarMannepalli SrikarMannepalli merged commit bafa898 into main Sep 1, 2023
@SrikarMannepalli SrikarMannepalli deleted the add-support-for-not-contains branch September 1, 2023 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants