Add webhook domain exclusion config for notification channels #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #172 +/- ##
============================================
+ Coverage 79.76% 79.90% +0.13%
+ Complexity 465 389 -76
============================================
Files 54 54
Lines 2333 2379 +46
Branches 92 103 +11
============================================
+ Hits 1861 1901 +40
- Misses 419 420 +1
- Partials 53 58 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
| validateRequestContextOrThrow(requestContext); | ||
| validateNotificationChannelMutableData(request.getNotificationChannelMutableData()); | ||
| validateWebhookConfigExclusionDomains( |
There was a problem hiding this comment.
done. Added validation for https support
avinashkolluru
approved these changes
Jul 19, 2023
avinashkolluru
previously approved these changes
Jul 19, 2023
@pavan-traceable this needs to be fixed. the android version of guava dep seems to be coming somehow. Please check. |
avinashkolluru
approved these changes
Jul 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add domain exclusion config for notification channel config service. This config will fail the creation/update of notification channels if it contains exclusion domains.