Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove exception logging from error log #167

Merged
merged 2 commits into from
Jun 12, 2023
Merged

Remove exception logging from error log #167

merged 2 commits into from
Jun 12, 2023

Conversation

sanket-mundra
Copy link
Contributor

Description

Please include a summary of the change, motivation and context.

Testing

Please describe the tests that you ran to verify your changes. Please summarize what did you test and what needs to be tested e.g. deployed and tested helm chart locally.

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

Documentation

Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.

@sanket-mundra sanket-mundra requested a review from skjindal93 June 12, 2023 12:43
@github-actions

This comment has been minimized.

@sanket-mundra sanket-mundra changed the title Logging exception only in case of debug Remove exception logging from error log Jun 12, 2023
@codecov
Copy link

codecov bot commented Jun 12, 2023

Codecov Report

Merging #167 (e9abf8b) into main (cecefcc) will decrease coverage by 0.01%.
The diff coverage is n/a.

❗ Current head e9abf8b differs from pull request most recent head c5a2345. Consider uploading reports for the commit c5a2345 to get more accurate results

@@             Coverage Diff              @@
##               main     #167      +/-   ##
============================================
- Coverage     79.74%   79.73%   -0.01%     
  Complexity      456      456              
============================================
  Files            54       54              
  Lines          2301     2300       -1     
  Branches         88       88              
============================================
- Hits           1835     1834       -1     
  Misses          415      415              
  Partials         51       51              
Flag Coverage Δ
integration 79.73% <ø> (-0.01%) ⬇️
unit 78.06% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...onfig/span/processing/utils/SpanFilterMatcher.java 90.00% <ø> (-0.15%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sanket-mundra sanket-mundra enabled auto-merge (squash) June 12, 2023 12:48
@github-actions

This comment has been minimized.

@sanket-mundra sanket-mundra merged commit 385a24e into main Jun 12, 2023
@sanket-mundra sanket-mundra deleted the fixLoggiing branch June 12, 2023 12:48
@github-actions
Copy link

Unit Test Results

  28 files  ±0    28 suites  ±0   45s ⏱️ ±0s
111 tests ±0  111 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 385a24e. ± Comparison against base commit cecefcc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants