Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix frame for NoImage Label #130

Merged
merged 1 commit into from
Apr 4, 2016
Merged

Fix frame for NoImage Label #130

merged 1 commit into from
Apr 4, 2016

Conversation

aashishdhawan
Copy link
Contributor

Corrects this following special case.

This happens in landscape mode. Where No Images available label is not centred.

simulator screen shot 02-apr-2016 8 58 33 pm

to
simulator screen shot 02-apr-2016 9 01 17 pm

@onmyway133
Copy link
Contributor

@aashishdhawan Thanks. But I see that the noImageLabel is already center-aligned now. On what device did that happen to you?

simulator screen shot 04 apr 2016 11 11 49

@aashishdhawan
Copy link
Contributor Author

@onmyway133 Portrait mode works fine. Issue is when you rotate screen. There are many UI issues in landscape mode. This is one of them.

@onmyway133
Copy link
Contributor

@aashishdhawan ah, I see. BTW, I think the PR should be a little more descriptive on what case it fixes 😇

@aashishdhawan
Copy link
Contributor Author

@onmyway133 Sure. My Mistake.

@zenangst zenangst merged commit ff8e0e6 into hyperoslo:master Apr 4, 2016
@zenangst
Copy link
Contributor

zenangst commented Apr 4, 2016

🚀

@onmyway133
Copy link
Contributor

@zenangst how about locking to portrait for iPhone?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants