Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/image selection #120

Merged
merged 4 commits into from
Mar 29, 2016
Merged

Fix/image selection #120

merged 4 commits into from
Mar 29, 2016

Conversation

onmyway133
Copy link
Contributor

When we select an image in galleryView, viewWillLayoutSubviews gets called and sets the frame again.
The problem is the gallery view gets moved down, as in this gif

untitled

@RamonGilabert does viewWillLayoutSubviews exist for some purpose?

@zenangst
Copy link
Contributor

Updated the travis configuration 😁

@@ -1,4 +1,4 @@
osx_image: xcode7.2
osx_image: xcode7.3
language: objective-c
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zenangst does language need to be Swift?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weirdly, no! 🌞

@RamonGilabert
Copy link
Contributor

What is the gif that you showed?

@zenangst
Copy link
Contributor

@RamonGilabert I'm guessing that is how it behaves on master.

@onmyway133
Copy link
Contributor Author

@RamonGilabert I edited the PR desc to make it clearer

@RamonGilabert RamonGilabert merged commit 319802b into master Mar 29, 2016
@RamonGilabert RamonGilabert deleted the fix/image_selection branch March 29, 2016 14:38
@RamonGilabert
Copy link
Contributor

🍣

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants