-
Notifications
You must be signed in to change notification settings - Fork 678
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/image selection #120
Fix/image selection #120
Conversation
Updated the travis configuration 😁 |
@@ -1,4 +1,4 @@ | |||
osx_image: xcode7.2 | |||
osx_image: xcode7.3 | |||
language: objective-c |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zenangst does language need to be Swift?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Weirdly, no! 🌞
What is the gif that you showed? |
@RamonGilabert I'm guessing that is how it behaves on |
@RamonGilabert I edited the PR desc to make it clearer |
🍣 |
When we select an image in galleryView,
viewWillLayoutSubviews
gets called and sets the frame again.The problem is the gallery view gets moved down, as in this gif
@RamonGilabert does
viewWillLayoutSubviews
exist for some purpose?