Removed totalCostLimit from MemoryConfig #184
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For NSCache, I think the totalCostLimit doesn't work if you don't use setObject(_ obj: ObjectType, forKey key: KeyType, cost g: Int) and pass a cost of the object which you want to cache.
Also, I think it's not easy to get the cost of each object since they may be any type. So keeping this property may confuse user when they really try to set it.
I checked several image cache libraries based on NSCache and found they did passed the cost of the cached images because it's easy to get an image cost.