-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Upsert Block and bump version to 1.2.0 #74
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 8 of 8 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @mangalaman93)
pydgraph/proto/api_pb2_grpc.py, line 4 at r1 (raw file):
import grpc from . import api_pb2 as api__pb2
I think you need to reverse this line manually or else there will be some issues. I don't remember the exact issue but it was complaining about the import path and this change is the fix for that.
2142cb3
to
916e16a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @martinmr)
pydgraph/proto/api_pb2_grpc.py, line 4 at r1 (raw file):
Previously, martinmr (Martin Martinez Rivera) wrote…
I think you need to reverse this line manually or else there will be some issues. I don't remember the exact issue but it was complaining about the import path and this change is the fix for that.
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @gitlw and @manishrjain)
This change is