Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Upsert Block and bump version to 1.2.0 #74

Merged
merged 4 commits into from
Jun 20, 2019

Conversation

mangalaman93
Copy link
Member

@mangalaman93 mangalaman93 commented Jun 17, 2019

This change is Reviewable

@mangalaman93 mangalaman93 changed the title Copy api.proto from dgo Add support for Upsert Block and bump version to 1.2.0 Jun 18, 2019
@mangalaman93 mangalaman93 marked this pull request as ready for review June 18, 2019 12:05
Copy link
Contributor

@martinmr martinmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 8 of 8 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @mangalaman93)


pydgraph/proto/api_pb2_grpc.py, line 4 at r1 (raw file):

import grpc

from . import api_pb2 as api__pb2

I think you need to reverse this line manually or else there will be some issues. I don't remember the exact issue but it was complaining about the import path and this change is the fix for that.

Copy link
Member Author

@mangalaman93 mangalaman93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @martinmr)


pydgraph/proto/api_pb2_grpc.py, line 4 at r1 (raw file):

Previously, martinmr (Martin Martinez Rivera) wrote…

I think you need to reverse this line manually or else there will be some issues. I don't remember the exact issue but it was complaining about the import path and this change is the fix for that.

Done.

@mangalaman93 mangalaman93 self-assigned this Jun 20, 2019
Copy link
Contributor

@martinmr martinmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @gitlw and @manishrjain)

@mangalaman93 mangalaman93 merged commit c506452 into master Jun 20, 2019
@mangalaman93 mangalaman93 deleted the aman/upsert branch June 20, 2019 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants