Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): change delete-on-updates to remove-on-update and set default false #9319

Merged
merged 11 commits into from
Mar 3, 2025
Merged

fix(core): change delete-on-updates to remove-on-update and set default false #9319

merged 11 commits into from
Mar 3, 2025

Conversation

harshil-goel
Copy link
Contributor

No description provided.

@harshil-goel harshil-goel requested a review from a team as a code owner February 25, 2025 14:10
@github-actions github-actions bot added area/core internal mechanisms go Pull requests that update Go code labels Feb 25, 2025
@trunk-io Trunk.io
Copy link

trunk-io bot commented Feb 25, 2025 •
edited
Loading

Static Badge   Static Badge   Static Badge   Static Badge

View Full Report ↗︎ ⋅ Docs

mangalaman93
mangalaman93 previously approved these changes Feb 25, 2025
View reviewed changes
@harshil-goel harshil-goel force-pushed the harshil-goel/update-delete-on branch from 9fe474e to eafe2be Compare February 27, 2025 12:34
@github-actions github-actions bot added area/integrations Related to integrations with other projects. area/testing Testing related issues labels Feb 28, 2025
@harshil-goel harshil-goel force-pushed the harshil-goel/update-delete-on branch from febd55f to 4ed79ce Compare March 3, 2025 06:22
@mangalaman93 mangalaman93 merged commit 8b19abf into main Mar 3, 2025
14 checks passed
@mangalaman93 mangalaman93 deleted the harshil-goel/update-delete-on branch March 3, 2025 12:33
harshil-goel added a commit that referenced this pull request Mar 3, 2025
@harshil-goel
fix(core): change delete-on-updates to remove-on-update and set defau…
4008de4 
…lt false (#9319)
@harshil-goel harshil-goel mentioned this pull request Mar 3, 2025
Merged
harshil-goel added a commit that referenced this pull request Mar 4, 2025
@harshil-goel @ryanfoxtyler
fix(core):change delete-on-update to remove-on-update and set default (…
f07c225 
…#9329)

#9305
#9307 
#9319

---------

Co-authored-by: Ryan Fox-Tyler <60440289+ryanfoxtyler@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mangalaman93 mangalaman93 mangalaman93 approved these changes

Assignees
No one assigned
Labels
area/core internal mechanisms area/integrations Related to integrations with other projects. area/testing Testing related issues go Pull requests that update Go code
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@harshil-goel @mangalaman93