Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancing Dgraph cd pipeline to only push images to Dockerhub when both AMD and ARM builds are successful #9202

Merged
merged 2 commits into from
Oct 24, 2024

Conversation

meghalims
Copy link
Contributor

Dgraph CD pipeline was prematurely publishing Docker images to DockerHub even when one of the architectures failed. This PR makes the following changes to prevent this:

  • dgraph-build-amd64 and dgraph-build-arm64 jobs build their respective images. But do not push them to DockerHub.
  • Job dgraph-docker-manifest is renamed to dgraph-docker-image-and-manifests-push to reflect that it also pushes docker images for Dgraph/Custom/Standalone

@meghalims meghalims requested a review from a team October 18, 2024 19:51
@github-actions github-actions bot added the area/integrations Related to integrations with other projects. label Oct 18, 2024
@mangalaman93 mangalaman93 force-pushed the megha/enhance-cd-pipeline branch from 7e64078 to 71fe363 Compare October 20, 2024 20:52
@mangalaman93 mangalaman93 merged commit 46545da into main Oct 24, 2024
14 checks passed
@mangalaman93 mangalaman93 deleted the megha/enhance-cd-pipeline branch October 24, 2024 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/integrations Related to integrations with other projects.
Development

Successfully merging this pull request may close these issues.

2 participants