Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use /tmp dir to store temporary index #4766

Merged
merged 2 commits into from
Feb 17, 2020
Merged

Use /tmp dir to store temporary index #4766

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
acec24d
Use /tmp dir to store temporary index
mangalaman93 Feb 13, 2020
f176a44
address comments
mangalaman93 Feb 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion posting/index.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ import (
"io/ioutil"
"math"
"os"
"path/filepath"
"sync/atomic"
"time"

Expand Down Expand Up @@ -541,7 +542,8 @@ func (r *rebuilder) Run(ctx context.Context) error {
// All the temp indexes go into the following directory. We delete the whole
// directory after the indexing step is complete. This deletes any other temp
// indexes that may have been left around in case defer wasn't executed.
tmpParentDir := "dgraph_index"
// TODO(Aman): If users are not happy, we could add a flag to choose this dir.
tmpParentDir := filepath.Join(os.TempDir(), "dgraph_index")

// We write the index in a temporary badger first and then,
// merge entries before writing them to p directory.
Expand Down