Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Client): Add DialCloud endpoint #147

Merged
merged 7 commits into from
Apr 21, 2021

Conversation

all-seeing-code
Copy link
Contributor

@all-seeing-code all-seeing-code commented Apr 1, 2021

  1. Adds DialCloudEndpoint method
  2. Adds deprecation message over DialSlashEndpoint method

This change is Reviewable

@all-seeing-code all-seeing-code changed the title BREAKING: Remove Slash endpoint fix(Client): Add DialCloudEndpoint Apr 20, 2021
Copy link
Contributor

@manishrjain manishrjain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @anurags92)


client.go, line 91 at r1 (raw file):

// DialCloudEndpoint creates a new TLS connection to a Dgraph Cloud backend
// It requires the backend endpoint as well as the api key

You should add a comment here which explains what to do next.

conn, err := dgo.DialCloud(...)
defer conn.Close()

dg := NewDgraphClient(api.NewDgraphClient(conn))

client.go, line 92 at r1 (raw file):

// DialCloudEndpoint creates a new TLS connection to a Dgraph Cloud backend
// It requires the backend endpoint as well as the api key
func DialCloudEndpoint(endpoint, key string) (*grpc.ClientConn, error) {

DialCloud

@all-seeing-code all-seeing-code merged commit 78a2fec into master Apr 21, 2021
@mangalaman93 mangalaman93 deleted the anurags92/SunsetSlashEndpoint branch March 22, 2023 06:43
@mangalaman93 mangalaman93 changed the title fix(Client): Add DialCloudEndpoint fix(Client): Add DialCloud Endpoint May 8, 2023
@mangalaman93 mangalaman93 changed the title fix(Client): Add DialCloud Endpoint fix(Client): Add DialCloud endpoint May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants