fix(GC): Set bits correctly for moved keys #1619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When keys are moved because of the GC, we were removing the bitDiscardEarlierVersions and other bits. Only the transaction markers should be removed and all the other bits should be kept.
NamanJain8
approved these changes
Dec 10, 2020
|
Approved by @manishrjain |
mYmNeo
added a commit
to mYmNeo/badger
that referenced
this pull request
Jan 17, 2023
Signed-off-by: thomassong <thomassong2012@gmail.com>
mYmNeo
added a commit
to mYmNeo/badger
that referenced
this pull request
Feb 13, 2023
Signed-off-by: thomassong <thomassong2012@gmail.com>
mYmNeo
added a commit
to mYmNeo/badger
that referenced
this pull request
Sep 14, 2024
Signed-off-by: thomassong <thomassong2012@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When keys are moved because of the GC, we were removing the
bitDiscardEarlierVersions and other bits. Only the transaction markers
should be removed and all the other bits should be kept.
This change is