release/v20.07: Remove vlog file if bootstrap, syncDir or mmap fails (#1434) #1436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The createVlogFile function creates a new vlog file. The function apart from creating a new file, bootstraps it, syncs it to the disk, and mmaps it. If any of the three operations fail, we will end up with a file on the disk but the vlog.maxFid will not be updated. On the next attempt to create the vlog files, we will get a "File already exists" error. This commit fixes this issue by removing the file if createVlogFile encounters any error. Fixes DGRAPH-1930 (cherry picked from commit dfcca75)
jarifibrahim
requested review from
ashish-goswami and
manishrjain
as code owners
stale
bot
added
the
status/stale
stale
bot
removed
the
status/stale
ahsanbarkati
approved these changes
Aug 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The createVlogFile function creates a new vlog file. The function apart
from creating a new file, bootstraps it, syncs it to the disk, and mmaps it.
If any of the three operations fail, we will end up with a file on the
disk but the vlog.maxFid will not be updated.
On the next attempt to create the vlog files, we will get a "File
already exists" error. This commit fixes this issue by removing the file
if createVlogFile encounters any error.
Fixes DGRAPH-1930
(cherry picked from commit dfcca75)
This change is