Reduce dependencies for library consumers #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cargo has the built-in feature to put examples in a dedicated folder. These executables have access to the additional [dev-dependencies]. Moving tokio with the full feature enabled there reduces the weight of the crate for consumers by quite a lot. No dependency version has been changed.
lmlmt
approved these changes
Dec 12, 2024
lmlmt
added a commit
that referenced
this pull request
Dec 21, 2024
|
Reverted in #73 as it broke the build (https://github.com/hyperliquid-dex/hyperliquid-rust-sdk/actions/runs/12447623886/job/34751307349). Feel free to re-open once fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
Cargo has the built-in feature to put examples in a dedicated folder. These executables have access to the additional [dev-dependencies], which can therefore be removed from the lib's dependencies. In particular, moving tokio with the "full" feature enabled to [dev-dependencies] reduces the weight of the crate for consumers by quite a lot.
I haven't changed the version of any dependency.