fix(state): use rw lock to prevent inconsitent state view #4867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Erigara
requested review from
s8sato,
mversic,
SamHSmith,
outoftardis,
0x009922,
DCNick3 and
dima74
as code owners
dima74
approved these changes
Jul 22, 2024
mversic
approved these changes
Jul 23, 2024
mversic
force-pushed
the
consistent_state
branch
from
05cc774
to
94c2abb
Compare
Signed-off-by: Shanin Roman <shanin1000@yandex.ru>
mversic
force-pushed
the
consistent_state
branch
from
94c2abb
to
16d6848
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While restarting iroha i've noticed that snapshot is inconsistent.
After some investigation i've noticed that assumption i had about the State was wrong (check this issue).
This PR fix this inconsistency by introducing lock which is used to guard block commit and prevent creation of inconsistent views of the State.
Benefits
Views are consistent.
Downsides
Rwlock has problems with writer starvation.