refactor: remove TriggeringEventFilterBox
#4866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mversic
requested review from
s8sato,
SamHSmith,
outoftardis,
Erigara,
0x009922,
DCNick3 and
dima74
as code owners
mversic
force-pushed
the
remove_triggering_event_filter_box
branch
4 times, most recently
from
a41865b
to
a824afd
Compare
|
In general i agree that strict typing in this case create more inconvenience than value. |
Erigara
approved these changes
Jul 22, 2024
mversic
force-pushed
the
remove_triggering_event_filter_box
branch
from
a824afd
to
ec25f64
Compare
mversic
force-pushed
the
remove_triggering_event_filter_box
branch
from
ec25f64
to
3bb0b8c
Compare
Erigara
force-pushed
the
remove_triggering_event_filter_box
branch
from
3bb0b8c
to
015e030
Compare
Signed-off-by: Marin Veršić <marin.versic101@gmail.com>
mversic
force-pushed
the
remove_triggering_event_filter_box
branch
from
015e030
to
ed886e6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I love static typing. It prevents many errors.
But there is a tradeoff between static typing and an API that is easy to use.
Sometimes too much static typing is difficult for end users
Linked issue
Closes #4376
Benefits
Checklist
CONTRIBUTING.md