-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: remove TriggeringEventFilterBox
#4866
refactor: remove TriggeringEventFilterBox
#4866
Conversation
a41865b
to
a824afd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still not sure why we should treat trigger completion event separately.
It was requested like that in #2885, but reasons are not specified.
In general i agree that strict typing in this case create more inconvenience than value. |
a824afd
to
ec25f64
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, good tradeoff.
ec25f64
to
3bb0b8c
Compare
3bb0b8c
to
015e030
Compare
Signed-off-by: Marin Veršić <marin.versic101@gmail.com>
015e030
to
ed886e6
Compare
Description
I love static typing. It prevents many errors.
But there is a tradeoff between static typing and an API that is easy to use.
Sometimes too much static typing is difficult for end users
Linked issue
Closes #4376
Benefits
Checklist
CONTRIBUTING.md