refactor: preserve voting block during block sync #4853
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change allow to preserve voting block during block sync until iroha have to drop it to process transactions.
It is done in two ways:
Linked issue
Closes #4834
Benefits
Preserve voting block in more cases.
Downsides
Resulting code is not pretty.
Because it has to handle soft-fork case explicitly and not just revert previous block and proceed.
How To Test