Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should we remove TriggeringEventFilterBox? #4376

Closed
mversic opened this issue Mar 19, 2024 · 1 comment · Fixed by #4866
Closed

Should we remove TriggeringEventFilterBox? #4376

mversic opened this issue Mar 19, 2024 · 1 comment · Fixed by #4866
Assignees
@mversic
Labels
iroha2-dev The re-implementation of a BFT hyperledger in RUST question Further information is requested

Comments

@mversic
Copy link
Contributor

mversic commented Mar 19, 2024 

          IMO we should remove `TriggeringEventFilterBox` and have only `EventFilterBox`. Is there a good reason why we have it?

Originally posted by @mversic in #4375 (comment)
@mversic mversic added question Further information is requested iroha2-dev The re-implementation of a BFT hyperledger in RUST labels Mar 19, 2024
@DCNick3
Copy link
Contributor

DCNick3 commented Mar 19, 2024 •
edited
Loading

Was introduced in #3789

@mversic mversic self-assigned this Jul 19, 2024
@mversic mversic mentioned this issue Jul 19, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mversic mversic

Labels
iroha2-dev The re-implementation of a BFT hyperledger in RUST question Further information is requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: remove TriggeringEventFilterBox mversic/iroha
2 participants
@DCNick3 @mversic