Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propose HIPE: Transports #94

Closed
wants to merge 5 commits into from

Conversation

TelegramSam
Copy link
Contributor

Signed-off-by: Sam Curren telegramsam@gmail.com

Signed-off-by: Sam Curren <telegramsam@gmail.com>
text/transports/README.md Outdated Show resolved Hide resolved
Signed-off-by: Sam Curren <telegramsam@gmail.com>
Signed-off-by: Sam Curren <telegramsam@gmail.com>

- The MIME Type for the POST request is `application/ssi-agent-wire`.

- A received message should be responded to with a 202 Accepted status code. This indicates that the request was received, but not necessarily processed. Accepting a 200 OK status code is allowed.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason why we can't have all 2XX status codes allowed here? As a transport definition, I feel it should allow for broader use of all Success status codes, including 201 Created, 204 No Content, etc.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think if we are to support a broader range of 2xx response codes, we should define what they indicate.

@kdenhartog
Copy link
Contributor

What's the extent of error handling that we want to cover with the transport layer. For example, would a misformatted wire message return a 4XX status code? I'd think that it wouldn't make sense to use the status code to push this error back. On the other hand, what about a message that is posted to the wrong endpoint? I would think that it would be acceptable to return a 4XX status code.

Also, given that we support IoT devices I think it's only fair to support the 418 status code if we're interacting with a teapot.

@TelegramSam
Copy link
Contributor Author

What's the extent of error handling that we want to cover with the transport layer. For example, would a misformatted wire message return a 4XX status code? I'd think that it wouldn't make sense to use the status code to push this error back. On the other hand, what about a message that is posted to the wrong endpoint? I would think that it would be acceptable to return a 4XX status code.

I do think we need to be careful here to not step into full message processing. Errors related to message receipt might be acceptable though.

Also, given that we support IoT devices I think it's only fair to support the 418 status code if we're interacting with a teapot.

Definitely need to work out the particulars of this one. :)

text/transports/README.md Outdated Show resolved Hide resolved
text/transports/README.md Outdated Show resolved Hide resolved

- POST requests are considered transmit only by default. No agent messages will be returned in the response. This behavior may be modified with additional signaling.

- Using HTTPS with TLS 1.2 or greater with a forward secret cipher will provide Perfect Forward Secrecy (PFS) on the transmission leg.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is true. However, the statement needs to be reconciled against the merged HIPE that says we will achieve perfect forward secrecy a different way.

@dhh1128
Copy link
Contributor

dhh1128 commented Mar 21, 2019

Aside from the comments I left, my other point of feedback is just that I think we need discussion of a few more issues and transports before we merge this. For example:

  1. How are different transports tested?
  2. How mediators and relays relate to transports (need hyperlinks to that HIPE)
  3. How message trust contexts might be affected by transports (or not).
  4. How to standardize handling of a new transport. (By raising a PR against this doc? If so, what questions would the PR have to answer?)
  5. Which transports have known implementations.

Signed-off-by: Sam Curren <telegramsam@gmail.com>
@TelegramSam
Copy link
Contributor Author

@dhh1128 I think I've addressed the points you mentioned. Any additional feedback is very welcome.

Oskar-van-Deventer added a commit to Oskar-van-Deventer/indy-hipe that referenced this pull request May 22, 2019
Signed-off-by: Oskar van Deventer oskar.vandeventer@tno.nl
@dhh1128
Copy link
Contributor

dhh1128 commented May 28, 2019

@TelegramSam I believe this PR is now superseded by Aries RFC 0025, so this PR can be closed. Correct?

@TelegramSam
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants