feat(Castor): extending createPrismDID to accept a KeyPair or PublicKey #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
milosh86
approved these changes
Aug 14, 2023
curtis-h
force-pushed
the
feature/ATL-4059
branch
from
81cc30a
to
f26f8da
Compare
Coverage reportBranches coverage not met for global: expected >=30%, but got 22.63157894736842%
Show new covered files 🐣
Test suite run success119 tests passing in 23 suites. Report generated by 🧪jest coverage report action from 71738ca |
curtis-h
force-pushed
the
feature/ATL-4059
branch
from
f26f8da
to
71738ca
Compare
atala-dev
added a commit
that referenced
this pull request
Aug 23, 2023
# [2.2.0](v2.1.0...v2.2.0) (2023-08-23) ### Bug Fixes * **Pluto:** encoding / decoding PrivateKeys ([#78](#78)) ([b9133ac](b9133ac)) ### Features * **Castor:** extending createPrismDID to accept a KeyPair or PublicKey ([#70](#70)) ([d06871c](d06871c)) * **Demo:** Update Mediator DID for demo apps ([#73](#73)) ([7f3c98e](7f3c98e))
github-actions bot
pushed a commit
that referenced
this pull request
Aug 23, 2023
# [2.2.0](v2.1.0...v2.2.0) (2023-08-23) ### Bug Fixes * **Pluto:** encoding / decoding PrivateKeys ([#78](#78)) ([b9133ac](b9133ac)) ### Features * **Castor:** extending createPrismDID to accept a KeyPair or PublicKey ([#70](#70)) ([d06871c](d06871c)) * **Demo:** Update Mediator DID for demo apps ([#73](#73)) ([7f3c98e](7f3c98e))
mixmix
pushed a commit
to mixmix/atala-prism-wallet-sdk-ts
that referenced
this pull request
May 6, 2024
…ey (hyperledger#70) Signed-off-by: Francisco Javier Ribó Labrador <elribonazo@gmail.com>
mixmix
pushed a commit
to mixmix/atala-prism-wallet-sdk-ts
that referenced
this pull request
May 6, 2024
# [2.2.0](hyperledger/identus-edge-agent-sdk-ts@v2.1.0...v2.2.0) (2023-08-23) ### Bug Fixes * **Pluto:** encoding / decoding PrivateKeys ([hyperledger#78](hyperledger#78)) ([b9133ac](hyperledger@b9133ac)) ### Features * **Castor:** extending createPrismDID to accept a KeyPair or PublicKey ([hyperledger#70](hyperledger#70)) ([d06871c](hyperledger@d06871c)) * **Demo:** Update Mediator DID for demo apps ([hyperledger#73](hyperledger#73)) ([7f3c98e](hyperledger@7f3c98e)) Signed-off-by: Francisco Javier Ribó Labrador <elribonazo@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Extended Castor.createPrismDID to accept KeyPair.
Kept the option to use a PublicKey for backwards compatibility.
Noticed only SECP256K1 keys work during testing, it looks to be by design, but is not indicated by the code?
Jira link
https://input-output.atlassian.net/browse/ATL-4059
Checklist