feat: Add Cryptography key abstraction for signable, verifiable keys, and also private and public base impls #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elribonazo
requested review from
milosh86,
curtis-h,
igdev0 and
goncalo-frade-iohk
# Conflicts: # src/apollo/Apollo.ts # src/apollo/utils/Ed25519KeyCommon.ts # src/apollo/utils/Ed25519KeyPair.ts # src/apollo/utils/Ed25519PrivateKey.ts # src/apollo/utils/Ed25519PublicKey.ts # src/apollo/utils/Secp256k1KeyCommon.ts # src/apollo/utils/Secp256k1KeyPair.ts # src/apollo/utils/Secp256k1PrivateKey.ts # src/apollo/utils/Secp256k1PublicKey.ts # src/apollo/utils/X25519KeyCommon.ts # src/apollo/utils/X25519KeyPair.ts # src/apollo/utils/X25519PrivateKey.ts # src/apollo/utils/X25519PublicKey.ts # src/castor/Castor.ts # src/castor/did/prismDID/PrismDIDPublicKey.ts
elribonazo
changed the title
elribonazo
changed the title
elribonazo
changed the title
milosh86
approved these changes
Jul 21, 2023
mixmix
pushed a commit
to mixmix/atala-prism-wallet-sdk-ts
that referenced
this pull request
May 6, 2024
… and also private and public base impls (hyperledger#67) Signed-off-by: Francisco Javier Ribó Labrador <elribonazo@gmail.com>
mixmix
pushed a commit
to mixmix/atala-prism-wallet-sdk-ts
that referenced
this pull request
May 6, 2024
…2.0.3...v2.1.0) (2023-08-17) * update dates parsing from JWT credentials ([hyperledger#66](hyperledger#66)) ([24562f7](hyperledger@24562f7)) * Add Cryptography key abstraction for signable, verifiable keys, and also private and public base impls ([hyperledger#67](hyperledger#67)) ([61d9dbd](hyperledger@61d9dbd)) Signed-off-by: Francisco Javier Ribó Labrador <elribonazo@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implemented basic cryptographic key abstraction, our plan is to introduce it now and extend this over time with more abstractions.
Current abstractions:
PrivateKeys have now the raw value always available without caring which key curve is used.
This abstraction has simplified our implementation of the agent too and we plan to extend it with more abstractions.
Exportable
Restorable
Derivable
Storable
Jira link
here
We have not changed the public API at all, so no updates in documentation are required.
Checklist