Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: e2e tests improvement #178

Merged
merged 4 commits into from
Feb 27, 2024

Conversation

elribonazo
Copy link
Contributor

Description

Improving the e2e tests with the latest breaking changes introduced for pluto.
E2E tests are using a pluto interface which has suffered some changes and needs to improve.

Will consider this completed when all the e2e tests run, after this, we must move the changes by cherry-pick to the release/2.10 branch.

thats it

Checklist

  • Self-reviewed the diff
  • New code has inline documentation
  • New code has proper comments/tests
  • Any changes not covered by tests have been tested manually

Copy link

github-actions bot commented Feb 27, 2024

Lines Statements Branches Functions
Coverage: 67%
67.07% (1691/2521) 53.37% (648/1214) 69.75% (512/734)

JUnit

Tests Skipped Failures Errors Time
383 2 💤 0 ❌ 0 🔥 57.493s ⏱️

@elribonazo elribonazo merged commit 6bc7ddd into master Feb 27, 2024
4 checks passed
@elribonazo elribonazo deleted the feature/e2e-tests-breaking-changes-pluto branch February 27, 2024 19:00
elribonazo added a commit that referenced this pull request Feb 27, 2024
atala-dev added a commit that referenced this pull request Feb 28, 2024
# [5.0.0](v4.0.0...v5.0.0) (2024-02-28)

### Bug Fixes

* add reference app + mediator live mode ([#177](#177)) ([6ebf48a](6ebf48a))
* e2e tests improvement ([#178](#178)) ([eb6a5ab](eb6a5ab))
* key's id name according to the DID Peer new specs [#126](#126) ([#148](#148)) ([a851b69](a851b69))
* Manually generating the missing changelog and breaking changes b… ([#167](#167)) ([24ecc04](24ecc04))
* Recover JTI field correctly. Allowing to regenerate the original JWT string ([#171](#171)) ([913f3fa](913f3fa))

* feat!: Implementing Pluto Repositories (#160) ([ce7669f](ce7669f)), closes [#160](#160)

### BREAKING CHANGES

* - Domain.Credential now has uuid (string) as an optional attribute in the class
- Change StorePrismDID Function parameters, removing keyPathIndex and privateKeyMetadataId which were not in use
- Small change in the getCredentialMetadata and getLinkSecret to return null when not found
- Change Pluto interface to use CredentialMetadata class VS what it was using before.
- Change Pluto interface, storeMediator now accepts a Mediator class and not 3 attributes, mediator, host and routing
- Rename storePrivateKeys to storePrivateKey
- Change Pluto interface, using Domain.PrismDID instead of Domain.PrismDID which is being removed
- Added new properties to handle Anoncreds credentials properties.
- Re-implemented Pluto which is now available again to all the users.

import SDK from "@atala/prism-wallet-sdk";
import IndexDB from "@pluto-encrypted/indexdb";

const store = new SDK.Store({
name: "test",
storage: IndexDB,
password: Buffer.from("demoapp").toString("hex")
});
const pluto = new SDK.Pluto(store, apollo);

Migrations, schemas, queries and error handling have been moved to the SDK again but user's which were using the existing storages can just pass the indexDB pluto-encrypted storage and it will integrate with the new db schemas, migrations, etc
elribonazo added a commit that referenced this pull request May 2, 2024
elribonazo pushed a commit that referenced this pull request May 2, 2024
# [5.0.0](v4.0.0...v5.0.0) (2024-02-28)

### Bug Fixes

* add reference app + mediator live mode ([#177](#177)) ([6ebf48a](6ebf48a))
* e2e tests improvement ([#178](#178)) ([eb6a5ab](eb6a5ab))
* key's id name according to the DID Peer new specs [#126](#126) ([#148](#148)) ([a851b69](a851b69))
* Manually generating the missing changelog and breaking changes b… ([#167](#167)) ([24ecc04](24ecc04))
* Recover JTI field correctly. Allowing to regenerate the original JWT string ([#171](#171)) ([913f3fa](913f3fa))

* feat!: Implementing Pluto Repositories (#160) ([ce7669f](ce7669f)), closes [#160](#160)

### BREAKING CHANGES

* - Domain.Credential now has uuid (string) as an optional attribute in the class
- Change StorePrismDID Function parameters, removing keyPathIndex and privateKeyMetadataId which were not in use
- Small change in the getCredentialMetadata and getLinkSecret to return null when not found
- Change Pluto interface to use CredentialMetadata class VS what it was using before.
- Change Pluto interface, storeMediator now accepts a Mediator class and not 3 attributes, mediator, host and routing
- Rename storePrivateKeys to storePrivateKey
- Change Pluto interface, using Domain.PrismDID instead of Domain.PrismDID which is being removed
- Added new properties to handle Anoncreds credentials properties.
- Re-implemented Pluto which is now available again to all the users.

import SDK from "@atala/prism-wallet-sdk";
import IndexDB from "@pluto-encrypted/indexdb";

const store = new SDK.Store({
name: "test",
storage: IndexDB,
password: Buffer.from("demoapp").toString("hex")
});
const pluto = new SDK.Pluto(store, apollo);

Migrations, schemas, queries and error handling have been moved to the SDK again but user's which were using the existing storages can just pass the indexDB pluto-encrypted storage and it will integrate with the new db schemas, migrations, etc
elribonazo added a commit that referenced this pull request May 2, 2024
Signed-off-by: Francisco Javier Ribó Labrador <elribonazo@gmail.com>
Signed-off-by: Francisco Javier Ribo Labrador <elribonazo@gmail.com>
elribonazo added a commit that referenced this pull request May 2, 2024
elribonazo pushed a commit that referenced this pull request May 2, 2024
# [5.0.0](v4.0.0...v5.0.0) (2024-02-28)

### Bug Fixes

* add reference app + mediator live mode ([#177](#177)) ([6ebf48a](6ebf48a))
* e2e tests improvement ([#178](#178)) ([eb6a5ab](eb6a5ab))
* key's id name according to the DID Peer new specs [#126](#126) ([#148](#148)) ([a851b69](a851b69))
* Manually generating the missing changelog and breaking changes b… ([#167](#167)) ([24ecc04](24ecc04))
* Recover JTI field correctly. Allowing to regenerate the original JWT string ([#171](#171)) ([913f3fa](913f3fa))

* feat!: Implementing Pluto Repositories (#160) ([ce7669f](ce7669f)), closes [#160](#160)

### BREAKING CHANGES

* - Domain.Credential now has uuid (string) as an optional attribute in the class
- Change StorePrismDID Function parameters, removing keyPathIndex and privateKeyMetadataId which were not in use
- Small change in the getCredentialMetadata and getLinkSecret to return null when not found
- Change Pluto interface to use CredentialMetadata class VS what it was using before.
- Change Pluto interface, storeMediator now accepts a Mediator class and not 3 attributes, mediator, host and routing
- Rename storePrivateKeys to storePrivateKey
- Change Pluto interface, using Domain.PrismDID instead of Domain.PrismDID which is being removed
- Added new properties to handle Anoncreds credentials properties.
- Re-implemented Pluto which is now available again to all the users.

import SDK from "@atala/prism-wallet-sdk";
import IndexDB from "@pluto-encrypted/indexdb";

const store = new SDK.Store({
name: "test",
storage: IndexDB,
password: Buffer.from("demoapp").toString("hex")
});
const pluto = new SDK.Pluto(store, apollo);

Migrations, schemas, queries and error handling have been moved to the SDK again but user's which were using the existing storages can just pass the indexDB pluto-encrypted storage and it will integrate with the new db schemas, migrations, etc
elribonazo added a commit that referenced this pull request May 3, 2024
elribonazo pushed a commit that referenced this pull request May 3, 2024
# [5.0.0](v4.0.0...v5.0.0) (2024-02-28)

### Bug Fixes

* add reference app + mediator live mode ([#177](#177)) ([6ebf48a](6ebf48a))
* e2e tests improvement ([#178](#178)) ([eb6a5ab](eb6a5ab))
* key's id name according to the DID Peer new specs [#126](#126) ([#148](#148)) ([a851b69](a851b69))
* Manually generating the missing changelog and breaking changes b… ([#167](#167)) ([24ecc04](24ecc04))
* Recover JTI field correctly. Allowing to regenerate the original JWT string ([#171](#171)) ([913f3fa](913f3fa))

* feat!: Implementing Pluto Repositories (#160) ([ce7669f](ce7669f)), closes [#160](#160)

### BREAKING CHANGES

* - Domain.Credential now has uuid (string) as an optional attribute in the class
- Change StorePrismDID Function parameters, removing keyPathIndex and privateKeyMetadataId which were not in use
- Small change in the getCredentialMetadata and getLinkSecret to return null when not found
- Change Pluto interface to use CredentialMetadata class VS what it was using before.
- Change Pluto interface, storeMediator now accepts a Mediator class and not 3 attributes, mediator, host and routing
- Rename storePrivateKeys to storePrivateKey
- Change Pluto interface, using Domain.PrismDID instead of Domain.PrismDID which is being removed
- Added new properties to handle Anoncreds credentials properties.
- Re-implemented Pluto which is now available again to all the users.

import SDK from "@atala/prism-wallet-sdk";
import IndexDB from "@pluto-encrypted/indexdb";

const store = new SDK.Store({
name: "test",
storage: IndexDB,
password: Buffer.from("demoapp").toString("hex")
});
const pluto = new SDK.Pluto(store, apollo);

Migrations, schemas, queries and error handling have been moved to the SDK again but user's which were using the existing storages can just pass the indexDB pluto-encrypted storage and it will integrate with the new db schemas, migrations, etc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants