Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Rollback Apollo integration #106

Merged
merged 4 commits into from
Oct 30, 2023
Merged

Conversation

elribonazo
Copy link
Contributor

@elribonazo elribonazo commented Oct 27, 2023

Description

We are removing Apollo integration as requested per requirements for the next 2.6 release.
We have also addressed 2 technical debt issues with key encoding, one with being base64Url encoded in raw and second, removing the extra data attribute inside JWK->X

Checklist

  • Self-reviewed the diff
  • New code has inline documentation
  • New code has proper comments/tests
  • Any changes not covered by tests have been tested manually

@github-actions
Copy link

github-actions bot commented Oct 27, 2023

Lines Statements Branches Functions
Coverage: 36%
35.43% (1370/3866) 24.83% (623/2509) 35.79% (403/1126)

JUnit

Tests Skipped Failures Errors Time
202 0 💤 0 ❌ 0 🔥 51.787s ⏱️

Signed-off-by: Francisco Javier Ribó Labrador <elribonazo@gmail.com>
Signed-off-by: Francisco Javier Ribó Labrador <elribonazo@gmail.com>
… be fixed by yarn upgrade deep dependencies.

Signed-off-by: Francisco Javier Ribó Labrador <elribonazo@gmail.com>
@elribonazo elribonazo marked this pull request as ready for review October 27, 2023 12:06
@elribonazo elribonazo changed the title fix: Rollback Apollo integration feat: Rollback Apollo integration Oct 27, 2023
@elribonazo elribonazo merged commit 854379a into master Oct 30, 2023
5 checks passed
@elribonazo elribonazo deleted the feature/apollo-rollback branch October 30, 2023 13:59
atala-dev added a commit that referenced this pull request Oct 31, 2023
# [2.5.0](v2.4.1...v2.5.0) (2023-10-31)

### Bug Fixes

* adding resolution for yarn ([#108](#108)) ([da60285](da60285))
* Integrate Apollo in Single branch. ([#94](#94)) ([bdc26e6](bdc26e6))
* remove unused packages and fix node demo ([#99](#99)) ([f9406d7](f9406d7))
* rollup config to handle anoncreds in node ([#109](#109)) ([0aa7fbc](0aa7fbc))

### Features

* adding anoncreds for ZKP ([#69](#69)) ([d57be19](d57be19))
* Rollback Apollo integration ([#106](#106)) ([854379a](854379a))
github-actions bot pushed a commit that referenced this pull request Oct 31, 2023
# [2.5.0](v2.4.1...v2.5.0) (2023-10-31)

### Bug Fixes

* adding resolution for yarn ([#108](#108)) ([da60285](da60285))
* Integrate Apollo in Single branch. ([#94](#94)) ([bdc26e6](bdc26e6))
* remove unused packages and fix node demo ([#99](#99)) ([f9406d7](f9406d7))
* rollup config to handle anoncreds in node ([#109](#109)) ([0aa7fbc](0aa7fbc))

### Features

* adding anoncreds for ZKP ([#69](#69)) ([d57be19](d57be19))
* Rollback Apollo integration ([#106](#106)) ([854379a](854379a))
mixmix pushed a commit to mixmix/atala-prism-wallet-sdk-ts that referenced this pull request May 6, 2024
Signed-off-by: Francisco Javier Ribó Labrador <elribonazo@gmail.com>
mixmix pushed a commit to mixmix/atala-prism-wallet-sdk-ts that referenced this pull request May 6, 2024
# [2.5.0](hyperledger/identus-edge-agent-sdk-ts@v2.4.1...v2.5.0) (2023-10-31)

### Bug Fixes

* adding resolution for yarn ([hyperledger#108](hyperledger#108)) ([da60285](hyperledger@da60285))
* Integrate Apollo in Single branch. ([hyperledger#94](hyperledger#94)) ([bdc26e6](hyperledger@bdc26e6))
* remove unused packages and fix node demo ([hyperledger#99](hyperledger#99)) ([f9406d7](hyperledger@f9406d7))
* rollup config to handle anoncreds in node ([hyperledger#109](hyperledger#109)) ([0aa7fbc](hyperledger@0aa7fbc))

### Features

* adding anoncreds for ZKP ([hyperledger#69](hyperledger#69)) ([d57be19](hyperledger@d57be19))
* Rollback Apollo integration ([hyperledger#106](hyperledger#106)) ([854379a](hyperledger@854379a))

Signed-off-by: Francisco Javier Ribó Labrador <elribonazo@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants