Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chat Sample app #76

Merged
merged 2 commits into from
Mar 6, 2023
Merged

Chat Sample app #76

merged 2 commits into from
Mar 6, 2023

Conversation

goncalo-frade-iohk
Copy link
Contributor

This PR is to merge the sample app and various issues that were identified.

I don't see a reason to verify the code within the Sample app that is on the Sample folder. So if you're reviewing you can disregard that part.

Besides that quite a few issues were found and dealt with while developing the app, this include:

Mercury:

  • didcomm library that we are using was not dealing well with async callbacks for the secrets. So instead now we are initiating the library with the resolvers each time they are requested.
  • ForwardMessaging was not implemented and that would prevent to send messages to a mediator, the proper logic is set right now.

@goncalo-frade-iohk goncalo-frade-iohk requested review from a team March 3, 2023 09:17
@goncalo-frade-iohk goncalo-frade-iohk changed the base branch from main to feature/AddDocumentationAndCIBuild March 3, 2023 09:18
@goncalo-frade-iohk goncalo-frade-iohk force-pushed the feature/SampleChatApp branch 3 times, most recently from 1f840fd to d80b37c Compare March 6, 2023 10:51
@goncalo-frade-iohk goncalo-frade-iohk force-pushed the feature/AddDocumentationAndCIBuild branch from 2588c31 to d93273f Compare March 6, 2023 11:32
Base automatically changed from feature/AddDocumentationAndCIBuild to main March 6, 2023 16:47
@goncalo-frade-iohk goncalo-frade-iohk merged commit 62654fd into main Mar 6, 2023
@goncalo-frade-iohk goncalo-frade-iohk deleted the feature/SampleChatApp branch March 6, 2023 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elribonazo elribonazo elribonazo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@goncalo-frade-iohk @elribonazo