Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Renaming #92

Merged
merged 1 commit into from
May 23, 2024
Merged

fix: Renaming #92

merged 1 commit into from
May 23, 2024

Conversation

CryptoKnightIOG
Copy link
Contributor

@CryptoKnightIOG CryptoKnightIOG changed the title ATL-7066: Renaming fix: Renaming May 16, 2024
Copy link
Contributor

@mkbreuningIOHK mkbreuningIOHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The main point is to keep the same links for the repos as they are not migrated yet.
Also, I am not sure about some links for the demo. Who would know?
@yshyn-iohk , would you like to review the links such as:

documentation/docs/identus/cloud-agent/authentication.md Outdated Show resolved Hide resolved
documentation/docs/identus/cloud-agent/authentication.md Outdated Show resolved Hide resolved
documentation/docs/identus/cloud-agent/authentication.md Outdated Show resolved Hide resolved
documentation/docs/identus/mediator.md Outdated Show resolved Hide resolved
documentation/docs/identus/overview.md Outdated Show resolved Hide resolved
documentation/docs/identus/overview.md Outdated Show resolved Hide resolved
documentation/docs/sidebars.js Show resolved Hide resolved
Copy link
Contributor

@mkbreuningIOHK mkbreuningIOHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some links changed could be first unchanged in a first step.
And then we see what to do.

You have modified the directory names so I would like this PR to be merged first as it seems the other PRs are dependent.

documentation/docs/concepts/multi-tenancy.md Outdated Show resolved Hide resolved
documentation/docs/concepts/multi-tenancy.md Outdated Show resolved Hide resolved
documentation/docs/concepts/multi-tenancy.md Outdated Show resolved Hide resolved
documentation/docs/concepts/multi-tenancy.md Outdated Show resolved Hide resolved
documentation/docs/concepts/multi-tenancy.md Outdated Show resolved Hide resolved
documentation/docs/identus/identus-cloud-agent/onboard.md Outdated Show resolved Hide resolved
documentation/docs/identus/identus-cloud-agent/onboard.md Outdated Show resolved Hide resolved
documentation/docs/identus/identus-cloud-agent/onboard.md Outdated Show resolved Hide resolved
documentation/docs/identus/cloud-agent/authentication.md Outdated Show resolved Hide resolved
documentation/docs/identus/cloud-agent/authentication.md Outdated Show resolved Hide resolved
documentation/docs/identus/overview.md Outdated Show resolved Hide resolved
documentation/docs/identus/overview.md Outdated Show resolved Hide resolved
@mkbreuningIOHK
Copy link
Contributor

mkbreuningIOHK commented May 23, 2024

Also, the PR check for documentation build fails with the error
image
This is caused by the fact that the directory docs/atala-prism/prism-mediator was renamed from atoll to identus.
image

But the change seems to have been done here in the branch, so this is strange: https://github.com/input-output-hk/atala-prism-docs/blob/ATL-7066-Renaming/documentation/docs/identus/mediator.md

Signed-off-by: Bassam Riman <bassam.riman@iohk.io>
@mkbreuningIOHK
Copy link
Contributor

After the new commit, the comments were all taken into account and the documentation build is working.

@CryptoKnightIOG CryptoKnightIOG merged commit 48f0373 into main May 23, 2024
4 checks passed
@CryptoKnightIOG CryptoKnightIOG deleted the ATL-7066-Renaming branch May 23, 2024 15:57
atala-dev added a commit that referenced this pull request May 24, 2024
## [1.94.1](v1.94.0...v1.94.1) (2024-05-24)

### ✨ Updates

* missing branch will prevent submodule update ([#91](#91)) ([d660e9f](d660e9f))
* Renaming ([#92](#92)) ([48f0373](48f0373))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants