Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove namespace param from remaining manager calls #875

Merged
merged 9 commits into from
Jun 22, 2022

Conversation

awrichar
Copy link
Contributor

Part of FIR-12
Follow-on to #864

This removes "namespace" as a param to remaining manager methods (since each manager is already assigned to a single namespace) and adds "namespace" as a param to most database queries (since all queries should be scoped to a single namespace).

awrichar added 8 commits June 22, 2022 16:06
Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
@codecov-commenter
Copy link

codecov-commenter commented Jun 22, 2022

Codecov Report

Merging #875 (5b55336) into main (2d0dbb9) will decrease coverage by 99.96%.
The diff coverage is n/a.

❗ Current head 5b55336 differs from pull request most recent head 43ed4a7. Consider uploading reports for the commit 43ed4a7 to get more accurate results

@@            Coverage Diff            @@
##             main   #875       +/-   ##
=========================================
- Coverage   99.96%      0   -99.97%     
=========================================
  Files         300      0      -300     
  Lines       19507      0    -19507     
=========================================
- Hits        19501      0    -19501     
+ Misses          5      0        -5     
+ Partials        1      0        -1     
Impacted Files Coverage Δ
...ternal/apiserver/route_delete_contract_listener.go
internal/apiserver/route_delete_subscription.go
internal/apiserver/route_get_chart_histogram.go
...ternal/apiserver/route_get_contract_api_by_name.go
...rnal/apiserver/route_get_contract_api_interface.go
...rnal/apiserver/route_get_contract_api_listeners.go
internal/apiserver/route_get_contract_apis.go
...erver/route_get_contract_interface_name_version.go
...nternal/apiserver/route_get_contract_interfaces.go
...erver/route_get_contract_listener_by_name_or_id.go
... and 290 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d0dbb9...43ed4a7. Read the comment docs.

Signed-off-by: Andrew Richardson <andrew.richardson@kaleido.io>
@nguyer nguyer merged commit cf843bc into hyperledger:main Jun 22, 2022
@nguyer nguyer deleted the managers branch June 22, 2022 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants