Allow use of FF object schema generator in custom schema defs for anyOf #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Of use cases Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
Codecov Report
@@ Coverage Diff @@
## main #20 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 29 29
Lines 1945 1949 +4
=========================================
+ Hits 1945 1949 +4
Continue to review full report at Codecov.
|
nguyer
approved these changes
Jun 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need a way to be able to define an
anyOfschema, which fits nicely with the advancedffapioption for returning a Schema directly. This is for the RPC-style APIs of connectors, where they take a bunch of different payloads that all have some common headers.However, currently this custom function can't access all the
structschema generation features, so you have to go fully manual - which seems wrong. So I've updated the interface.I believe all uses of this customization in FireFly core were removed perviously, because of this kind of restriction meaning they are were too static. We took the hit on losing the extra info on the API description, in favor of ensuring it stayed up to date. So this PR should also open the door to re-instating that going forwards.